diff options
| author | Sam Meredith <[email protected]> | 2025-12-27 18:28:18 -0300 |
|---|---|---|
| committer | Fabio Estevam <[email protected]> | 2025-12-29 10:17:00 -0300 |
| commit | ff1932daab1e6381e0b26d69a0197dfb2cd7168f (patch) | |
| tree | 4dd12e1ccd8608a1a92a7dc20c7618b2588cb1d5 /drivers/video | |
| parent | f24a2124d26eb6b1aab3b20923359ede80105a8b (diff) | |
video: mxsfb: fix pixel clock polarity
DISPLAY_FLAGS_PIXDATA_NEGEDGE means the controller drives the data on
pixel clocks falling edge. That is DOTCLK_POL=0 (default) not 1.
The mxsfb-drm driver in the Linux kernel has made the same change and it
remains to this day:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?h=v6.19-rc2&id=53990e416bb7adaa59d045f325a47f31a11b75ee
I found this was required on an IMX8X SoM.
Without the patch a splash screen displays with aliasing-like jagged edges.
Signed-off-by: Sam Meredith <[email protected]>
[fabio: Put more information into the commit log]
Signed-off-by: Fabio Estevam <[email protected]>
Diffstat (limited to 'drivers/video')
| -rw-r--r-- | drivers/video/mxsfb.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/video/mxsfb.c b/drivers/video/mxsfb.c index e72839cead4..71429a43e06 100644 --- a/drivers/video/mxsfb.c +++ b/drivers/video/mxsfb.c @@ -159,7 +159,7 @@ static void mxs_lcd_init(struct udevice *dev, u32 fb_addr, vdctrl0 |= LCDIF_VDCTRL0_HSYNC_POL; if(flags & DISPLAY_FLAGS_VSYNC_HIGH) vdctrl0 |= LCDIF_VDCTRL0_VSYNC_POL; - if(flags & DISPLAY_FLAGS_PIXDATA_NEGEDGE) + if (flags & DISPLAY_FLAGS_PIXDATA_POSEDGE) vdctrl0 |= LCDIF_VDCTRL0_DOTCLK_POL; if(flags & DISPLAY_FLAGS_DE_HIGH) vdctrl0 |= LCDIF_VDCTRL0_ENABLE_POL; |