diff options
| author | Sam Protsenko <[email protected]> | 2023-11-07 11:34:17 -0600 |
|---|---|---|
| committer | Minkyu Kang <[email protected]> | 2023-11-13 16:20:58 +0900 |
| commit | 2227f4c0afed9fef940ace67d1482417eb876316 (patch) | |
| tree | 20618dc3078182dca47b333166b6846899573acf /drivers | |
| parent | 08cfa971a717ff6aedf52066efb9e227eaa7aac4 (diff) | |
serial: s5p: Fix clk_get_by_index() error code check
clk_get_by_index() returns negative number on error. Assigning it to
unsigned int makes the subsequent "ret < 0" check always false, leading
in turn to possible unhandled errors. Change 'ret' variable type to
signed int so the code checks and handles clk_get_by_index() return code
properly.
Signed-off-by: Sam Protsenko <[email protected]>
Fixes: cf75cdf96ef2 ("serial: s5p: use clock api to get clock rate")
Signed-off-by: Minkyu Kang <[email protected]>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/serial/serial_s5p.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/serial/serial_s5p.c b/drivers/serial/serial_s5p.c index 7aeb8c0f8cb..fe52580d64d 100644 --- a/drivers/serial/serial_s5p.c +++ b/drivers/serial/serial_s5p.c @@ -118,7 +118,7 @@ int s5p_serial_setbrg(struct udevice *dev, int baudrate) #if IS_ENABLED(CONFIG_CLK_EXYNOS) || IS_ENABLED(CONFIG_ARCH_APPLE) struct clk clk; - u32 ret; + int ret; ret = clk_get_by_index(dev, 1, &clk); if (ret < 0) |