diff options
| author | Casey Connolly <[email protected]> | 2026-03-20 16:45:41 +0100 |
|---|---|---|
| committer | Casey Connolly <[email protected]> | 2026-03-24 11:49:17 +0100 |
| commit | 4577a672eceaf7494cc42f9df05401e7beeab0b1 (patch) | |
| tree | 533bad94339c910ce87f5d21b22fba3c07ae0f1b /drivers | |
| parent | 7f09aff39924c9bce4ac12379c5f624ce7004d43 (diff) | |
qcom: rpmh: don't error for SLEEP requests
Just stub out non-active votes, if we return an error the caller may
propagate it and not send its active vote. Since we don't suspend
there's no risk of us entering a broken state due to missing votes.
Link: https://patch.msgid.link/20260320-casey-qcom-rpmh-serial-fixes-v1-2-b81d05832eec@linaro.org
Signed-off-by: Casey Connolly <[email protected]>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/soc/qcom/rpmh-rsc.c | 8 | ||||
| -rw-r--r-- | drivers/soc/qcom/rpmh.c | 4 |
2 files changed, 6 insertions, 6 deletions
diff --git a/drivers/soc/qcom/rpmh-rsc.c b/drivers/soc/qcom/rpmh-rsc.c index dce61f26229..0b821cc6f9d 100644 --- a/drivers/soc/qcom/rpmh-rsc.c +++ b/drivers/soc/qcom/rpmh-rsc.c @@ -261,8 +261,8 @@ static struct tcs_group *get_tcs_for_msg(struct rsc_drv *drv, * just always used the first active TCS. */ if (msg->state != RPMH_ACTIVE_ONLY_STATE) { - log_err("WARN: only ACTIVE_ONLY state supported\n"); - return ERR_PTR(-EINVAL); + log_debug("WARN: only ACTIVE_ONLY state supported\n"); + return NULL; } return &drv->tcs[ACTIVE_TCS]; @@ -390,8 +390,8 @@ int rpmh_rsc_send_data(struct rsc_drv *drv, const struct tcs_request *msg) u32 val; tcs = get_tcs_for_msg(drv, msg); - if (IS_ERR(tcs)) - return PTR_ERR(tcs); + if (IS_ERR_OR_NULL(tcs)) + return 0; /* U-Boot is single-threaded, always use the first TCS as we'll never conflict */ tcs_id = tcs->offset; diff --git a/drivers/soc/qcom/rpmh.c b/drivers/soc/qcom/rpmh.c index 8c222324c66..b55e23c4417 100644 --- a/drivers/soc/qcom/rpmh.c +++ b/drivers/soc/qcom/rpmh.c @@ -60,8 +60,8 @@ static int __rpmh_write(const struct udevice *dev, enum rpmh_state state, struct rpmh_ctrlr *ctrlr = get_rpmh_ctrlr(dev); if (state != RPMH_ACTIVE_ONLY_STATE) { - log_err("only ACTIVE_ONLY state supported\n"); - return -EINVAL; + log_debug("WARN: Only ACTIVE_ONLY state supported\n"); + return 0; } return rpmh_rsc_send_data(ctrlr_to_drv(ctrlr), &rpm_msg->msg); |