summaryrefslogtreecommitdiff
path: root/drivers
diff options
context:
space:
mode:
authorTom Rini <[email protected]>2025-08-19 11:26:16 -0600
committerTom Rini <[email protected]>2025-08-19 11:26:16 -0600
commit5b2c3a3ea154f81fa61095e1e192484048fb3c78 (patch)
tree4d34e68d01b2875f148e33a32e4eae9f721dbe08 /drivers
parentcf11b98f139c996bf60c0abe20d343060c4fef26 (diff)
parent13ca68b104ea75d54e86816ba6d86ef5e70a2668 (diff)
Merge patch series "soc: ti: k3-navss-ringacc: Fix Smatch reported issues"
Andrew Goodbody <[email protected]> says: Smatch reported issues including a derference of a pointer before its NULL check and the use of an uninitialised variable. Link: https://lore.kernel.org/r/[email protected]
Diffstat (limited to 'drivers')
-rw-r--r--drivers/soc/ti/k3-navss-ringacc.c6
1 files changed, 4 insertions, 2 deletions
diff --git a/drivers/soc/ti/k3-navss-ringacc.c b/drivers/soc/ti/k3-navss-ringacc.c
index 14114a65830..d37c454143b 100644
--- a/drivers/soc/ti/k3-navss-ringacc.c
+++ b/drivers/soc/ti/k3-navss-ringacc.c
@@ -632,12 +632,14 @@ err_free_ops:
int k3_nav_ringacc_ring_cfg(struct k3_nav_ring *ring,
struct k3_nav_ring_cfg *cfg)
{
- struct k3_nav_ringacc *ringacc = ring->parent;
+ struct k3_nav_ringacc *ringacc;
int ret = 0;
if (!ring || !cfg)
return -EINVAL;
+ ringacc = ring->parent;
+
if (ringacc->dual_ring)
return k3_dmaring_ring_cfg(ring, cfg);
@@ -930,7 +932,7 @@ static int k3_nav_ringacc_probe_dt(struct k3_nav_ringacc *ringacc)
ringacc->num_rings = dev_read_u32_default(dev, "ti,num-rings", 0);
if (!ringacc->num_rings) {
- dev_err(dev, "ti,num-rings read failure %d\n", ret);
+ dev_err(dev, "ti,num-rings read failure\n");
return -EINVAL;
}