diff options
| author | Andrew Goodbody <[email protected]> | 2025-08-18 11:44:29 +0100 |
|---|---|---|
| committer | Jerome Forissier <[email protected]> | 2025-08-18 15:47:58 +0200 |
| commit | c4526c390a3c4ea1c4f244b6436ebbb74902769a (patch) | |
| tree | 32bbe5e987136445ef2fcd881fe731e8a23cc609 /drivers | |
| parent | 783ea37c7b52ae088e8c64581fbe412b5dc9a878 (diff) | |
phy: cadence: torrent: Set an error code for return
In cdns_torrent_phy_probe the test for too many lanes configured does
not set an error code before taking the error path. This could lead to a
silent failure if the calling code does not detect the error. Add the
code to return -EINVAL in this case.
This issue was found by Smatch.
Signed-off-by: Andrew Goodbody <[email protected]>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/phy/cadence/phy-cadence-torrent.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/phy/cadence/phy-cadence-torrent.c b/drivers/phy/cadence/phy-cadence-torrent.c index 1f566d082f9..28fe026223c 100644 --- a/drivers/phy/cadence/phy-cadence-torrent.c +++ b/drivers/phy/cadence/phy-cadence-torrent.c @@ -719,6 +719,7 @@ static int cdns_torrent_phy_probe(struct udevice *dev) if (total_num_lanes > MAX_NUM_LANES) { dev_err(dev, "Invalid lane configuration\n"); + ret = -EINVAL; goto put_lnk_rst; } |