diff options
| author | Rasmus Villemoes <[email protected]> | 2022-05-12 09:33:07 +0200 |
|---|---|---|
| committer | Tom Rini <[email protected]> | 2022-08-08 10:50:20 -0400 |
| commit | c62b74652a330b09e2157b6ebc1f4d9ea3cec254 (patch) | |
| tree | 1ccb84bb1c05a6f884024f3be55dc0c86b0b1e8e /drivers | |
| parent | 0c999ce98e9d6485f8637e130f7612f80c111a0e (diff) | |
net: dwc_eth_qos: remove use of DWC_NET_PHYADDR
Only two boards in the tree set the macro DWC_NET_PHYADDR. Both have
CONFIG_DM_ETH_PHY=y, so should set the phy address in DT if necessary.
The imx8mp_evk does set the correct address in device tree.
The other board seems to be a copy-paste-adapt from an old
version of the imx8mp_evk config header, given the "#ifdef
CONFIG_DWC_ETH_QOS" block that has been removed from imx8mp_evk header
in commit 127fb454955. Its device tree doesn't even enable (i.e., set
'status = "okay"') the &eqos node. But the other ethernet device,
&fec, does get enabled, and does have a phy sitting at address 4 (and
it also has a corresponding legacy #define CONFIG_FEC_MXC_PHYADDR
4). So I believe it should be completely safe to remove it from there
as well.
Signed-off-by: Rasmus Villemoes <[email protected]>
Reviewed-by: Ramon Fried <[email protected]>
[trini: Re-apply to top of tree, update imx93_evk.h]
Signed-off-by: Tom Rini <[email protected]>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/net/dwc_eth_qos.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/drivers/net/dwc_eth_qos.c b/drivers/net/dwc_eth_qos.c index 4f3ea4f6295..43af7d91f81 100644 --- a/drivers/net/dwc_eth_qos.c +++ b/drivers/net/dwc_eth_qos.c @@ -789,9 +789,6 @@ static int eqos_start(struct udevice *dev) if (!eqos->phy) { int addr = -1; addr = eqos_get_phy_addr(eqos, dev); -#ifdef DWC_NET_PHYADDR - addr = DWC_NET_PHYADDR; -#endif eqos->phy = phy_connect(eqos->mii, addr, dev, eqos->config->interface(dev)); if (!eqos->phy) { |