diff options
| author | Dan Carpenter <[email protected]> | 2023-08-03 13:29:34 +0300 |
|---|---|---|
| committer | Tom Rini <[email protected]> | 2023-08-08 17:41:52 -0400 |
| commit | 08404fa2087946bb370430d466fe5011f18ef072 (patch) | |
| tree | 6c755cfa5c0428970564da2b5c11c0df18785d4a /fs/btrfs | |
| parent | 939390b203dde8a0176dbfa272dcb7bc54949baf (diff) | |
btrfs: fix some error checking for btrfs_decompress()
The btrfs_decompress() function mostly (u32)-1 on error but it can
also return -EPERM or other kernel error codes from zstd_decompress().
The "ret" variable is an int, so we could just check for negatives.
Signed-off-by: Dan Carpenter <[email protected]>
Reviewed-by: Qu Wenruo <[email protected]>
Diffstat (limited to 'fs/btrfs')
| -rw-r--r-- | fs/btrfs/inode.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c index 38e285bf94b..4691612eda3 100644 --- a/fs/btrfs/inode.c +++ b/fs/btrfs/inode.c @@ -390,7 +390,7 @@ int btrfs_read_extent_inline(struct btrfs_path *path, csize); ret = btrfs_decompress(btrfs_file_extent_compression(leaf, fi), cbuf, csize, dbuf, dsize); - if (ret == (u32)-1) { + if (ret < 0) { ret = -EIO; goto out; } @@ -500,7 +500,7 @@ int btrfs_read_extent_reg(struct btrfs_path *path, ret = btrfs_decompress(btrfs_file_extent_compression(leaf, fi), cbuf, csize, dbuf, dsize); - if (ret == (u32)-1) { + if (ret < 0) { ret = -EIO; goto out; } |