diff options
| author | Tom Rini <[email protected]> | 2024-11-18 08:24:06 -0600 |
|---|---|---|
| committer | Tom Rini <[email protected]> | 2024-11-18 08:24:06 -0600 |
| commit | 0e6432e19f9c812b4986ca7fd8e6db9fd2c199d3 (patch) | |
| tree | 8cea1d6d85b2141ecb3491bcf28115e80dc5e797 /include | |
| parent | a38390284ad4261723d3a2411ba988828e994535 (diff) | |
| parent | 6ea8dc661b04ddd5c19163932ee12705c53f552a (diff) | |
Merge patch series "Fix boot failure due to misaligned DMA buffer"
Nam Cao <[email protected]> says:
We observed the following sporadic boot failure while booting from MMC
device:
=> boot
CACHE: Misaligned operation at range [9efa25f8, 9efa27f8]
CACHE: Misaligned operation at range [9efa25f8, 9efa27f8]
CACHE: Misaligned operation at range [9efa25f8, 9efa27f8]
CACHE: Misaligned operation at range [9efa25f8, 9efa27f8]
** Booting bootflow '[email protected]_1' with extlinux
Ignoring unknown command: �D���D��
Boot failed (err=-14)
The reason is because while allocating buffer to read a file from MMC,
alignment of 1 byte is used. Thus, the buffer doesn't work for performing
DMA, and garbage data is read.
While looking at this issue, I also noticed that if no alignment specified
(align=0) then fs_read_alloc() is documented to use the default. But the
default is no alignment. Therefore, other users of fs_read_alloc() which
specify align=0 may be broken as well.
The first patch changes extlinux_read_bootflow() to use proper buffer
alignment for DMA.
The second patch changes the default alignment of fs_read_alloc() to be
DMA-suitable, to fix other potential bugs.
Diffstat (limited to 'include')
| -rw-r--r-- | include/fs.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/include/fs.h b/include/fs.h index 63727567ccc..2474880385d 100644 --- a/include/fs.h +++ b/include/fs.h @@ -325,7 +325,7 @@ int do_fs_types(struct cmd_tbl *cmdtp, int flag, int argc, char * const argv[]); * * @fname: Filename to read * @size: Size of file to read (must be correct!) - * @align: Alignment to use for memory allocation (0 for default) + * @align: Alignment to use for memory allocation (0 for default: ARCH_DMA_MINALIGN) * @bufp: On success, returns the allocated buffer with the nul-terminated file * in it * Return: 0 if OK, -ENOMEM if out of memory, -EIO if read failed |