diff options
| author | Tom Rini <[email protected]> | 2023-06-16 19:05:52 -0400 |
|---|---|---|
| committer | Tom Rini <[email protected]> | 2023-06-16 19:05:52 -0400 |
| commit | 1c30e10017ec8bcd0ffec0d8c7d17539ae73dfa7 (patch) | |
| tree | 6120a7d1a99c25b50896a7d932d431145570f5a4 /lib/efi_loader | |
| parent | 2f4664f5c3edc55b18d8906f256a4c8e303243c0 (diff) | |
| parent | 5669591dd8d2b21bc79237b161107300eb7f2b12 (diff) | |
Merge tag 'efi-2023-07-rc5' of https://source.denx.de/u-boot/custodians/u-boot-efi
Pull request efi-2023-07-rc5
Documentation:
* man-page for imxtract
* correct EVT_DM_POST_INIT_F description
UEFI:
* bootm: don't call booti_setup for EFI images
* simplify efi_disk_remove
* fix tests that failed when executed repeatedly
Diffstat (limited to 'lib/efi_loader')
| -rw-r--r-- | lib/efi_loader/efi_disk.c | 91 |
1 files changed, 26 insertions, 65 deletions
diff --git a/lib/efi_loader/efi_disk.c b/lib/efi_loader/efi_disk.c index d2256713a8e..28c8cdf7100 100644 --- a/lib/efi_loader/efi_disk.c +++ b/lib/efi_loader/efi_disk.c @@ -690,91 +690,52 @@ int efi_disk_probe(void *ctx, struct event *event) return 0; } -/* - * Delete an efi_disk object for a whole raw disk +/** + * efi_disk_remove - delete an efi_disk object for a block device or partition * - * @dev uclass device (UCLASS_BLK) + * @ctx: event context: driver binding protocol + * @event: EV_PM_PRE_REMOVE event * - * Delete an efi_disk object which is associated with @dev. - * The type of @dev must be UCLASS_BLK. + * Delete an efi_disk object which is associated with the UCLASS_BLK or + * UCLASS_PARTITION device for which the EV_PM_PRE_REMOVE event is raised. * - * @return 0 on success, -1 otherwise + * Return: 0 on success, -1 otherwise */ -static int efi_disk_delete_raw(struct udevice *dev) +int efi_disk_remove(void *ctx, struct event *event) { + enum uclass_id id; + struct udevice *dev = event->data.dm.dev; efi_handle_t handle; struct blk_desc *desc; - struct efi_disk_obj *diskobj; + struct efi_disk_obj *diskobj = NULL; if (dev_tag_get_ptr(dev, DM_TAG_EFI, (void **)&handle)) - return -1; + return 0; - desc = dev_get_uclass_plat(dev); - if (desc->uclass_id != UCLASS_EFI_LOADER) { + id = device_get_uclass_id(dev); + switch (id) { + case UCLASS_BLK: + desc = dev_get_uclass_plat(dev); + if (desc && desc->uclass_id != UCLASS_EFI_LOADER) + diskobj = container_of(handle, struct efi_disk_obj, + header); + break; + case UCLASS_PARTITION: diskobj = container_of(handle, struct efi_disk_obj, header); - efi_free_pool(diskobj->dp); + break; + default: + return 0; } - efi_delete_handle(handle); - dev_tag_del(dev, DM_TAG_EFI); - - return 0; -} - -/* - * Delete an efi_disk object for a disk partition - * - * @dev uclass device (UCLASS_PARTITION) - * - * Delete an efi_disk object which is associated with @dev. - * The type of @dev must be UCLASS_PARTITION. - * - * @return 0 on success, -1 otherwise - */ -static int efi_disk_delete_part(struct udevice *dev) -{ - efi_handle_t handle; - struct efi_disk_obj *diskobj; - - if (dev_tag_get_ptr(dev, DM_TAG_EFI, (void **)&handle)) - return -1; - - diskobj = container_of(handle, struct efi_disk_obj, header); + if (diskobj) + efi_free_pool(diskobj->dp); - efi_free_pool(diskobj->dp); efi_delete_handle(handle); dev_tag_del(dev, DM_TAG_EFI); return 0; } -/* - * Delete an efi_disk object for a block device - * - * @dev uclass device (UCLASS_BLK or UCLASS_PARTITION) - * - * Delete an efi_disk object which is associated with @dev. - * The type of @dev must be either UCLASS_BLK or UCLASS_PARTITION. - * This function is expected to be called at EV_PM_PRE_REMOVE. - * - * @return 0 on success, -1 otherwise - */ -int efi_disk_remove(void *ctx, struct event *event) -{ - enum uclass_id id; - struct udevice *dev; - - dev = event->data.dm.dev; - id = device_get_uclass_id(dev); - - if (id == UCLASS_BLK) - return efi_disk_delete_raw(dev); - else if (id == UCLASS_PARTITION) - return efi_disk_delete_part(dev); - else - return 0; -} - /** * efi_disk_get_device_name() - get U-Boot device name associated with EFI handle * |
