diff options
| author | Michal Suchanek <[email protected]> | 2022-10-12 21:57:59 +0200 |
|---|---|---|
| committer | Simon Glass <[email protected]> | 2022-10-17 21:17:12 -0600 |
| commit | c726fc01cf669e3e2979da8665ef660e7d3ba464 (patch) | |
| tree | 5d11dc2d0e58fac8a08cb1e2425ff0ae10ad0a8a /test/fuzz | |
| parent | 8676ae36ae4617b20b5cc49972c54c63c7b27bb3 (diff) | |
dm: treewide: Use uclass_first_device_err when accessing one device
There is a number of users that use uclass_first_device to access the
first and (assumed) only device in uclass.
Some check the return value of uclass_first_device and also that a
device was returned which is exactly what uclass_first_device_err does.
Some are not checking that a device was returned and can potentially
crash if no device exists in the uclass. Finally there is one that
returns NULL on error either way.
Convert all of these to use uclass_first_device_err instead, the return
value will be removed from uclass_first_device in a later patch.
Signed-off-by: Michal Suchanek <[email protected]>
Reviewed-by: Simon Glass <[email protected]>
Diffstat (limited to 'test/fuzz')
| -rw-r--r-- | test/fuzz/cmd_fuzz.c | 2 | ||||
| -rw-r--r-- | test/fuzz/virtio.c | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/test/fuzz/cmd_fuzz.c b/test/fuzz/cmd_fuzz.c index 0cc01dc199c..e2f44f3ecb6 100644 --- a/test/fuzz/cmd_fuzz.c +++ b/test/fuzz/cmd_fuzz.c @@ -29,7 +29,7 @@ static struct udevice *find_fuzzing_engine(void) { struct udevice *dev; - if (uclass_first_device(UCLASS_FUZZING_ENGINE, &dev)) + if (uclass_first_device_err(UCLASS_FUZZING_ENGINE, &dev)) return NULL; return dev; diff --git a/test/fuzz/virtio.c b/test/fuzz/virtio.c index e5363d5638e..8a47667e778 100644 --- a/test/fuzz/virtio.c +++ b/test/fuzz/virtio.c @@ -30,7 +30,7 @@ static int fuzz_vring(const uint8_t *data, size_t size) return 0; /* check probe success */ - if (uclass_first_device(UCLASS_VIRTIO, &bus) || !bus) + if (uclass_first_device_err(UCLASS_VIRTIO, &bus)) panic("Could not find virtio bus\n"); /* check the child virtio-rng device is bound */ |