diff options
| author | Anton Ivanov <[email protected]> | 2026-06-02 19:27:52 +0100 |
|---|---|---|
| committer | Tom Rini <[email protected]> | 2026-06-13 10:42:17 -0600 |
| commit | f3d2ff3f5c3f49216b45a30b4b9a315a1b8d2142 (patch) | |
| tree | 8a3452ce0628247f697acfa6f83fff20a0d67c2b /tools | |
| parent | 69f6272b24a26c17a5b6de3b041218ec57239943 (diff) | |
fdt: Check return value of fdt_get_name() calls
fdt_get_name() can return NULL and set len to a negative error code.
fdt_find_regions() does not check for this, leading to a potential NULL
pointer dereference and a buffer out-of-bounds write during signature
verification of an untrusted FIT. fdt_next_region(), fdt_check_full(),
and display_fdt_by_regions() also lack validation.
Add NULL checks and propagate the error code from fdt_get_name()
to the caller.
Signed-off-by: Anton Ivanov <[email protected]>
Reviewed-by: Simon Glass <[email protected]>
Diffstat (limited to 'tools')
| -rw-r--r-- | tools/fdtgrep.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/tools/fdtgrep.c b/tools/fdtgrep.c index b4c041070f5..dba7240001f 100644 --- a/tools/fdtgrep.c +++ b/tools/fdtgrep.c @@ -355,6 +355,9 @@ static int display_fdt_by_regions(struct display_info *disp, const void *blob, case FDT_BEGIN_NODE: name = fdt_get_name(blob, offset, &len); + if (!name) + return len; + fprintf(f, "%*s%s {", depth++ * shift, "", *name ? name : "/"); break; |