1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
|
# SPDX-License-Identifier: GPL-2.0+
# Copyright 2026 Canonical Ltd.
#
# Test mkimage import of external data in fit_import_data()
"""Regression test for stale per-image state in fit_import_data().
The import loop used to keep the data pointer and external property name
of the previous image, so an image node carrying data-size but neither
data-offset nor data-position imported the previous image's data and
then made mkimage abort without printing any diagnostic. Such a node
must be skipped by the import and reported by the later processing
stages instead.
"""
import os
import subprocess
import pytest
import fit_util
BASE_ITS = '''
/dts-v1/;
/ {
description = "import-data test";
images {
kernel-1 {
description = "first kernel";
data = /incbin/("%(kernel1)s");
type = "kernel";
arch = "sandbox";
os = "linux";
compression = "none";
load = <0x40000>;
entry = <0x40000>;
};
kernel-2 {
description = "second kernel";
data = /incbin/("%(kernel2)s");
type = "kernel";
arch = "sandbox";
os = "linux";
compression = "none";
load = <0x80000>;
entry = <0x80000>;
};
};
configurations {
default = "conf-1";
conf-1 {
kernel = "kernel-1";
};
};
};
'''
@pytest.mark.boardspec('sandbox')
@pytest.mark.requiredtool('dtc')
@pytest.mark.requiredtool('fdtput')
def test_fit_import_data_missing_offset(ubman):
"""An image with data-size but no data-offset must not inherit data"""
mkimage = os.path.join(ubman.config.build_dir, 'tools/mkimage')
params = {
'kernel1': fit_util.make_kernel(ubman, 'imp-kernel1.bin', 'first'),
'kernel2': fit_util.make_kernel(ubman, 'imp-kernel2.bin', 'second'),
}
its = fit_util.make_its(ubman, BASE_ITS, params, 'imp.its')
itb = fit_util.make_fname(ubman, 'imp.itb')
result = subprocess.run([mkimage, '-E', '-f', its, itb],
capture_output=True, text=True)
assert result.returncode == 0, result.stderr
# Remove the offset so that only data-size is left on kernel-2
subprocess.run(['fdtput', '-d', itb, '/images/kernel-2', 'data-offset'],
check=True)
# Re-processing must skip the malformed image in the import, so that
# the hashing stage reports it; previously the stale pointer made the
# import write kernel-1's data into kernel-2 and abort silently
result = subprocess.run([mkimage, '-F', itb],
capture_output=True, text=True)
assert result.returncode != 0
assert "Can't get image data/size" in result.stderr
|
