user-jakobl-CodeQL-Testinguser-jakobl-CodeQL-Testing

1 files changed, 16 insertions, 13 deletions

diff --git a/tools/sdv/samples/SDV-FailDriver-WDM/driver/fail_driver1.c b/tools/sdv/samples/SDV-FailDriver-WDM/driver/fail_driver1.c
index 19f27900..9dc9e91f 100644
--- a/tools/sdv/samples/SDV-FailDriver-WDM/driver/fail_driver1.c
+++ b/tools/sdv/samples/SDV-FailDriver-WDM/driver/fail_driver1.c
@@ -34,6 +34,21 @@ Environment:
 #pragma alloc_text (PAGE, DriverUnload)
 #endif
 
+// CodeQL Injected Defect #1:
+int foo1(int n1, unsigned short delta) {
+    return n1 + delta < n1; // BAD
+}
+
+// CodeQL Injected Defect #2:
+int foo2(int n1, unsigned short delta) {
+    return n1 + delta < n1; // BAD
+}
+
+// CodeQL Injected Defect #3:
+int foo3(int n1, unsigned short delta) {
+    return n1 + delta < n1; // BAD
+}
+
 NTSTATUS
 DriverEntry(
     _In_ PDRIVER_OBJECT  DriverObject,
@@ -121,22 +136,10 @@ DispatchCreate (
 
     PAGED_CODE();
     
-    // Injected defects for testing CodeQL CI:
-    unsigned long x=42;
-    unsigned long y=43;
-    unsigned long long z;
-    
-    // Injected defects #1:
-    z = x*y;
-
-    // Injected defects #2:
-    z = x*y;
-
-    // Injected defects #3:
-    z = x*y;
 
     ExFreePool(badPointer);
 
+
     extension = (PDRIVER_DEVICE_EXTENSION)DeviceObject -> DeviceExtension;
 
     ProcessorMask   =  (KAFFINITY)1;