diff options
| author | ruki <[email protected]> | 2021-02-27 00:41:40 +0800 |
|---|---|---|
| committer | ruki <[email protected]> | 2021-02-27 00:41:40 +0800 |
| commit | f5c5b95be6882bfecb4485927dced531d76028f9 (patch) | |
| tree | 9d3b86d7c6bba03ddc061115f2f44c7915d26489 | |
| parent | 261f8c4f4308f68ddce8eadf36de75dd9282f6f4 (diff) | |
add some comments
| -rw-r--r-- | xmake/modules/package/tools/cmake.lua | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/xmake/modules/package/tools/cmake.lua b/xmake/modules/package/tools/cmake.lua index 6b390e075..8b3b606fd 100644 --- a/xmake/modules/package/tools/cmake.lua +++ b/xmake/modules/package/tools/cmake.lua @@ -228,6 +228,8 @@ function _get_configs_for_windows(package, configs, opt) table.insert(configs, "x64") end end + -- we maybe need patch `cmake_policy(SET CMP0091 NEW)` to enable this argument for some packages + -- @see https://github.com/xmake-io/xmake-repo/pull/303 local vs_runtime = package:config("vs_runtime") if vs_runtime == "MT" then table.insert(configs, "-DCMAKE_MSVC_RUNTIME_LIBRARY=MultiThreaded") |