summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorruki <[email protected]>2024-03-23 00:45:38 +0800
committerruki <[email protected]>2024-03-23 00:45:38 +0800
commitcffe3388442b419a39daed160c98a7ccff1432bb (patch)
tree9faa33dfad9943e487b1576c7e5181ffbec06517
parenta3a7f76fe2f10792cedf4198d2b5db51f64cb721 (diff)
update comments
-rw-r--r--xmake/modules/package/manager/system/find_package.lua5
1 files changed, 4 insertions, 1 deletions
diff --git a/xmake/modules/package/manager/system/find_package.lua b/xmake/modules/package/manager/system/find_package.lua
index 2a7b4727c..0d0db8a18 100644
--- a/xmake/modules/package/manager/system/find_package.lua
+++ b/xmake/modules/package/manager/system/find_package.lua
@@ -66,8 +66,11 @@ function main(name, opt)
end
snippet_configs.links = snippet_configs.links or name
- -- we need to check package toolchain first
+ -- We need to check package toolchain first
-- https://github.com/xmake-io/xmake/issues/4596#issuecomment-2014528801
+ --
+ -- But if it depends on some toolchain packages,
+ -- then they can't be detected early in the fetch and we have to disable system.find_package
if opt.package and not _check_package_toolchains(opt.package) then
return
end