summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorruki <[email protected]>2021-02-21 18:24:03 +0800
committerruki <[email protected]>2021-02-21 18:24:03 +0800
commit4ef736be23496aac5a68beb3c4f36e94d5c5b3fd (patch)
treeaa323a089889d563839de6eb7d0244fce0132d68
parent0d918cd313d6df1a07bebaff687d744ef5522e50 (diff)
improve should_install
-rw-r--r--xmake/modules/private/action/require/impl/install_packages.lua2
-rw-r--r--xmake/modules/private/action/require/install.lua2
2 files changed, 2 insertions, 2 deletions
diff --git a/xmake/modules/private/action/require/impl/install_packages.lua b/xmake/modules/private/action/require/impl/install_packages.lua
index 765b71c3d..48f159313 100644
--- a/xmake/modules/private/action/require/impl/install_packages.lua
+++ b/xmake/modules/private/action/require/impl/install_packages.lua
@@ -407,7 +407,7 @@ function _should_install(instance)
if instance:parents() then
-- if all the packages that depend on it already exist, then there is no need to install it
for _, parent in pairs(instance:parents()) do
- if not parent:exists() then
+ if _should_install(parent) and not parent:exists() then
return true
end
end
diff --git a/xmake/modules/private/action/require/install.lua b/xmake/modules/private/action/require/install.lua
index 7d6ec3556..5477d999d 100644
--- a/xmake/modules/private/action/require/install.lua
+++ b/xmake/modules/private/action/require/install.lua
@@ -32,7 +32,7 @@ function _should_install(instance)
if instance:parents() then
-- if all the packages that depend on it already exist, then there is no need to install it
for _, parent in pairs(instance:parents()) do
- if not parent:exists() then
+ if _should_install(parent) and not parent:exists() then
return true
end
end