summaryrefslogtreecommitdiff
path: root/core/src
diff options
context:
space:
mode:
authorruki <[email protected]>2023-04-14 00:38:45 +0800
committerruki <[email protected]>2023-04-14 00:38:45 +0800
commit9385a3b2784284512d7799493a1ebf154edfeeae (patch)
treee78a5b1e8d29c82d68080a4b30d827012206d444 /core/src
parent9b7b385d97e7e6a7750a6d3c1f54a434b635cc9e (diff)
update changelog and add some comments for #3628
Diffstat (limited to 'core/src')
-rwxr-xr-xcore/src/demo/xmake.sh10
1 files changed, 10 insertions, 0 deletions
diff --git a/core/src/demo/xmake.sh b/core/src/demo/xmake.sh
index 1c0bca6bf..9233f1c30 100755
--- a/core/src/demo/xmake.sh
+++ b/core/src/demo/xmake.sh
@@ -28,6 +28,16 @@ target "demo"
add_installfiles "${projectdir}/(xmake/templates/**)" "share"
add_installfiles "${projectdir}/scripts/xrepo.sh" "bin" "xrepo"
+ # fix os.exec() call incorrect program from /mingw64/bin. e.g. python, ..
+ #
+ # because xmake is installed to /mingw64/bin/xmake,
+ # os.exec/CreateProcess always gives the highest priority to finding the process from /mingw64/bin (if it exists),
+ # rather than from the $PATH environment variable.
+ #
+ # we install the xmake executable into a separate directory to ensure
+ # that os.exec() does not look for additional executables.
+ #
+ # @see https://github.com/xmake-io/xmake/issues/3628
if is_host "msys"; then
add_installfiles "${projectdir}/scripts/msys/xmake.sh" "bin" "xmake"
add_installfiles "${buildir}/xmake.exe" "share/xmake"