summaryrefslogtreecommitdiff
path: root/include
diff options
context:
space:
mode:
authorRasmus Villemoes <[email protected]>2022-10-28 13:50:51 +0200
committerStefan Roese <[email protected]>2022-11-02 08:41:42 +0100
commit6b84b1db2d69609a783ab2fd6990c9e72903d367 (patch)
tree6be338c661d689c9cb1b7e64dd046b283785a0e0 /include
parentd7de5ef629352fe12ad99b6539ba1480b923f31e (diff)
cyclic: drop redundant cyclic_ready flag
We're already relying on gd->cyclic being NULL before cyclic_init() is called - i.e., we're relying on all of gd being zeroed before entering any C code. And when we do populate gd->cyclic, its ->cyclic_ready member is automatically set to true. So we can actually just rely on testing gd->cyclic itself. The only wrinkle is that cyclic_uninit() actually did set ->cyclic_ready to false. However, since it doesn't free gd->cyclic, the cyclic infrastructure is actually still ready (i.e., the list_head is properly initialized as an empty list). Signed-off-by: Rasmus Villemoes <[email protected]> Reviewed-by: Stefan Roese <[email protected]> Tested-by: Stefan Roese <[email protected]> Tested-by: Tim Harvey <[email protected]> # imx8mm-venice-*
Diffstat (limited to 'include')
-rw-r--r--include/cyclic.h2
1 files changed, 0 insertions, 2 deletions
diff --git a/include/cyclic.h b/include/cyclic.h
index 50427baa3f4..263b74d89b8 100644
--- a/include/cyclic.h
+++ b/include/cyclic.h
@@ -18,11 +18,9 @@
* struct cyclic_drv - Cyclic driver internal data
*
* @cyclic_list: Cylic list node
- * @cyclic_ready: Flag if cyclic infrastructure is ready
*/
struct cyclic_drv {
struct list_head cyclic_list;
- bool cyclic_ready;
};
/**